Skip to content

Ensure we always show backend error in automation and script editor#8139

Merged
spacegaier merged 3 commits intohome-assistant:devfrom
spacegaier:automation-script-error-msg
Jan 13, 2021
Merged

Ensure we always show backend error in automation and script editor#8139
spacegaier merged 3 commits intohome-assistant:devfrom
spacegaier:automation-script-error-msg

Conversation

@spacegaier
Copy link
Copy Markdown
Member

Breaking change

Proposed change

I have an automation currently that I cannot save due to some backend failöure (separate issue). However, in that case the frontend only shows an empty toast as the backend is not actually providing a proper error message.

This PR ensures that we at least show the more generic error to inform the user.

Debug screenshot of generic backend response:
image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

spacegaier and others added 2 commits January 13, 2021 19:07
@spacegaier spacegaier merged commit 6919d0c into home-assistant:dev Jan 13, 2021
@spacegaier spacegaier deleted the automation-script-error-msg branch January 13, 2021 19:45
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants